Skip to content

Implementing Loom Provider 2 (WebSocket + JSON RPC) #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Implementing Loom Provider 2 (WebSocket + JSON RPC) #303

wants to merge 21 commits into from
+5,041 −277

Conversation

eduardonunesp
Copy link
Contributor

@eduardonunesp eduardonunesp commented Aug 26, 2019 •
edited
Loading

  • Depends on Loomchain eth_sendRawTransaction eth_sendRawTransaction modified to support ethereum transactions loomchain#1227
  • Update e2e configs with new Loomchain configs
  • Replicate tests from original Loom Provider
  • Import code from test branch
  • Use stable version of Web3 1.2.1 (WebsocketProvider) as reference
  • Loom Provider 2 using WebSocket as default
  • WebSocket communication and eth_subscribe/eth_unsubscribe tracking by Loom Provider 2
  • Adding retry strategies like original Loom Provider
  • Wallet management on ethers/Wallet
  • Signed transaction from ethers/Wallet
  • JSON RPC documentation on Loom Developers Site (https://loomx.io/developers/en/json-rpc-methods.html)

@eduardonunesp eduardonunesp changed the title [WIP] Initial tests on Loom Provider 2 [WIP] Implementing Loom Provider 2 (WebSocket + JSON RPC) Aug 26, 2019
@enlight enlight mentioned this pull request Sep 24, 2019
Merged
@enlight
Copy link
Contributor

enlight commented Sep 24, 2019

The main difference between the current version of LoomProvider and this new one is that this one is meant to work more like a wallet provider, similar to the HD wallet provider (https://www.trufflesuite.com/tutorials/using-infura-custom-provider). It interacts directly with the /eth endpoint on Loom nodes (and only that endpoint), both for querying and sending txs, the latter requires loomnetwork/loomchain#1227.

@eduardonunesp
Copy link
Contributor Author

Totally agree with you, the LoomProvider2 right now is doing that the accounts and sign the transactions are happening on the provider other stuff related to /eth are delegated. However, I noticed that LoomProvider2 still needs to manage the listeners for the WebSocket connections, so the Web3 will use those Websocket "intefaces"

enlight
enlight requested changes Oct 17, 2019
View reviewed changes
Copy link
Contributor

@enlight enlight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase this PR on master, nothing in src/mainnet-contracts should've changed in this PR

@eduardonunesp eduardonunesp changed the title [WIP] Implementing Loom Provider 2 (WebSocket + JSON RPC) Implementing Loom Provider 2 (WebSocket + JSON RPC) Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enlight enlight enlight requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eduardonunesp @enlight